[Webkit-unassigned] [Bug 106216] [EFL][WK2] Expose accessibility hierarchy in WebKit2-EFL.

Tue Jan 15 16:47:16 PST 2013

https://bugs.webkit.org/show_bug.cgi?id=106216

Gyuyoung Kim <gyuyoung.kim at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #182733|review?                     |review-
               Flag|                            |

--- Comment #23 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2013-01-15 16:49:00 PST ---
(From update of attachment 182733)
View in context: https://bugs.webkit.org/attachment.cgi?id=182733&action=review

r- because of GTK build fail and wrong UNUSED_PARAM usage.

> Source/WebKit2/WebProcess/WebPage/WebPage.h:83
> +#include "GRefPtr.h"

#if HAVE(ACCESSIBILITY) && (PLATFORM(GTK) || PLATFORM(EFL)) How about this one ?

> Source/WebKit2/WebProcess/WebPage/WebPage.h:474
> +#if HAVE(ACCESSIBILITY)

ditto ?

> Source/WebKit2/WebProcess/WebPage/WebPage.h:850
> +#elif PLATFORM(GTK) || (PLATFORM(EFL) && HAVE(ACCESSIBILITY))

ditto ?

> Source/WebKit2/WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp:78
> +#if PLATFORM(EFL)

As I said in comment #19, WebKit prefers to remove unused parameter. Look at this mailling list. - http://lists.webkit.org/pipermail/webkit-dev/2012-October/022369.html

> Source/WebKit2/WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp:112
> +#if PLATFORM(EFL)

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.