[Webkit-unassigned] [Bug 106929] Text Autosizing: extend preOrderTraversal to handle different traversal modes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106929





--- Comment #2 from John Mellor <johnme at chromium.org>  2013-01-15 11:55:21 PST ---
(From update of attachment 182813)
View in context: https://bugs.webkit.org/attachment.cgi?id=182813&action=review

Cool, this is a nice cleanup and lets us do more powerful traversals (like bug 106792 is trying to do). Kenneth/Julien, does this look good?

> Source/WebCore/rendering/TextAutosizer.cpp:299
> +            (renderer == container) ? NormalTraversal : SkipDescendantsOfContainers);

Nit: WebKit doesn't often wrap long lines (except comments). Perhaps break this into two lines, where the first line sets a temporary |traversalMode| variable?

> Source/WebCore/rendering/TextAutosizer.h:60
> +    enum TraversalMode {

Nit: perhaps TraversalFilter would be clearer? Don't mind, your call...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.