[Webkit-unassigned] [Bug 106895] [chromium] move setMockDeviceOrientation to TestRunner library

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106895


jochen at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #182745|review?                     |review-
               Flag|                            |




--- Comment #3 from jochen at chromium.org  2013-01-15 06:03:28 PST ---
(From update of attachment 182745)
View in context: https://bugs.webkit.org/attachment.cgi?id=182745&action=review

> Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:89
> +    virtual WebKit::WebDeviceOrientationClientMock* deviceOrientationClientMock() { return 0; }

content_shell doesn't have a mock, but a real client. I think instead of adding the mock to the delegate interface, we should add a setDeviceOrientation() callback.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.