[Webkit-unassigned] [Bug 93980] [WK2] Implement testRunner.setUseDeferredFrameLoading

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93980


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #173585|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #4 from Benjamin Poulain <benjamin at webkit.org>  2013-01-14 14:37:59 PST ---
(From update of attachment 173585)
View in context: https://bugs.webkit.org/attachment.cgi?id=173585&action=review

Thank you for looking into this.

> LayoutTests/platform/efl-wk2/TestExpectations:-199
> -# testRunner.setUseDeferredFrameLoading() is not implemented in WK2. Skipped so it does not generate PNG results.
> -webkit.org/b/93980 http/tests/appcache/load-from-appcache-defer-resume-crash.html [ Skip ]
> -

What about gtk-wk2?

> Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:116
> +    // The InjectedBundle is already asynchronous so we don't need to implement it
> +    void setUseDeferredFrameLoading(bool) { }

Doing that would be wrong. Any future test that would do "setUseDeferredFrameLoading(false)" would use an unimplemented feature.
(What you could have done instead is rename the method so that it can only be set. E.g. forceDeferredFrameLoading().)

I also think not doing anything is probably wrong. WebPage seems to have an API for deferredFrameLoading: WebPage::setDefersLoading().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.