[Webkit-unassigned] [Bug 105337] Expose mutation observers to chromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105337





--- Comment #13 from Dane Walllinga <dgwallinga at chromium.org>  2013-01-14 12:42:40 PST ---
(From update of attachment 180057)
View in context: https://bugs.webkit.org/attachment.cgi?id=180057&action=review

>> Source/WebKit/chromium/ChangeLog:6
>> +        Create WebMutation{whatever} wrappers for existing WebKit classes, exposing functionality needed by chromium to detect DOM changes for the new autofill flow
> 
> I think the main question with this patch is whether this is a good idea.  Can you explain how you plan to use these APIs in the autofill flow?  Will you need to create mutation observers for all (or a large fraction) of web pages?  My understanding is that the presence of mutation observers slows down DOM operations.

We'll need to create mutation observers for a whitelisted set of web pages belonging to multipage autofill flows (for a related bug on the chromium side, maybe check https://codereview.chromium.org/11539003/). Basically we need to be able to support autofill behavior on pages with ajax-y stuff, which means knowing when dom changes happen so we can query the autofill server again. Initially maybe around 20 sites, though potentially more going forward. You are correct that this could have some performance impact on dom operations, but the improvements to autofill should speed up the user experience overall.

>> Source/WebKit/chromium/public/WebMutationObserver.h:37
>> +#include "platform/WebVector.h"
> 
> We've changed the style for these sorts of includes.

May I ask what to?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.