[Webkit-unassigned] [Bug 104835] Web Inspector: Don't throw exceptions in WebInspector.Color

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 14 05:58:50 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=104835





--- Comment #9 from Alexander Pavlov (apavlov) <apavlov at chromium.org>  2013-01-14 06:00:38 PST ---
(From update of attachment 180367)
View in context: https://bugs.webkit.org/attachment.cgi?id=180367&action=review

One test nit, otherwise the change looks good to me

> LayoutTests/inspector/styles/styles-invalid-color-values-expected.txt:75
> +FAIL: Error parsing color 'none'.

This should be rephrased, since the "FAIL:" prefix is reserved for test failures and should normally never occur in test expectations (and the right prefix to use here is either "SUCCESS:" or nothing at all, since none of the previous colors have this prefix)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list