[Webkit-unassigned] [Bug 104773] [EFL] Quit debug build without -DSHARED_CORE=ON

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104773


Laszlo Gombos <laszlo.gombos at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #182280|review?                     |review-
               Flag|                            |




--- Comment #17 from Laszlo Gombos <laszlo.gombos at webkit.org>  2013-01-12 21:25:19 PST ---
(From update of attachment 182280)
View in context: https://bugs.webkit.org/attachment.cgi?id=182280&action=review

r- to make sure that this patch is only applied to the EFL port.

> CMakeLists.txt:11
> +if (${CMAKE_BUILD_TYPE} MATCHES "^[Dd][Ee][Bb][Uu][Gg]$" AND NOT SHARED_CORE)

As far as I can tell this rule is only needed for the EFL port, but this line will be evaluated for all ports. Can we instead move this logic to OptionsEfl.cmake ?

Can we use the following line instead before checking for the build type
string(TOLOWER ${CMAKE_BUILD_TYPE} CMAKE_BUILD_TYPE)

> CMakeLists.txt:12
> +    message(FATAL_ERROR "Debug build need set -DSHARED_CORE=ON")

How about 'Turn on the SHARED_CORE flag to make a debug build - e.g. build-webkit --efl --debug --cmakeargs="-DSHARED_CORE=ON" ' as most people use build-webkit.

My preference is option 2 as the only way to make a debug build and the moment is using this option, so I do not see a problem automatically setting it for debug builds, but both option 1 and option 2 is better than what we have now so I do not have a strong preference.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.