[Webkit-unassigned] [Bug 105650] Quadratic and bezier curves with coincident endpoints rendered incorrectly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105650


Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #182310|review?                     |review-
               Flag|                            |




--- Comment #11 from Kenneth Russell <kbr at google.com>  2013-01-11 10:41:23 PST ---
(From update of attachment 182310)
View in context: https://bugs.webkit.org/attachment.cgi?id=182310&action=review

Thanks for the tests. They need a little more work and a clean EWS run.

> LayoutTests/fast/canvas/canvas-bezier-same-endpoint.html:39
> +shouldBeBlue(70,70);

Per the other test below, I think sampling exactly on the line / degenerate curve is too fragile. I think you should sample a few pixels which cross the line, and assert that at least one of them was actually drawn (i.e., wasn't the background color).

> LayoutTests/fast/canvas/canvas-bezier-same-endpoint.html:45
> +shouldBeBlue(75,75);

Same here.

> LayoutTests/fast/canvas/canvas-bezier-same-endpoint.html:49
> +ctx.stroke();

Please test filling of a curve as well as stroking. A degenerate bezier can cover significant area so you can sample the interior in a few places and ensure it was drawn.

> LayoutTests/fast/canvas/canvas-quadratic-same-endpoint.html:37
> +shouldBeYellow(50,50);

Because this test is failing on Mac it looks like it is too fragile. I think you should sample a few pixels which cross the degenerate curve, and assert that at least one was drawn (i.e., wasn't the background color). Also, please test filling as well as stroking the path.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.