[Webkit-unassigned] [Bug 105451] Unable to place caret in RTL Override Characters by mouse click

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105451





--- Comment #10 from Yi Shen <max.hong.shen at gmail.com>  2013-01-11 10:16:23 PST ---
Thanks for the comments.
(In reply to comment #9)
> (From update of attachment 182230 [details])
> > Source/WebCore/platform/text/BidiResolver.h:509
> > +        if (run && (run->stop() - run->start() == 1)) {
> 
> Why do we do this only when the difference between the start and the stop is 1?
According to http://unicode.org/reports/tr9/#L1, we need to reset the level for 1) Segment separators, 2) Paragraph separators, 3) Any sequence of whitespace characters preceding a segment separator or paragraph separator, and 4)Any sequence of white space characters at the end of the line.

It seems the BidiResolver won't create runs for 3) and 4), so I added a condition here to say we only reset the level for the run which only has one character. I will double check this.
> 
> > Source/WebCore/platform/text/BidiResolver.h:510
> > +            BidiContext* c = context();
> 
> Please don't use one letter variable.
Will fix it.
> 
> > Source/WebCore/platform/text/BidiResolver.h:511
> > +            while (c->parent())
> 
> Is this correct with respect to the way we implement unicode-bidi: -webkit-isolate and unicode-bidi: -webkit-plaintext?
> I definitely would like to see tests for these.
Will check this.
> 
> > LayoutTests/editing/selection/click-on-rtl-text.html:10
> > +<div id="description">This test that clicking on the editable RTL text correctly places the caret between the RTL characters.</div>
> > +<textarea id="editor" cols="100" rows="3">a&#8238;AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
> 
> Could you create a LTR equivalent?
Will add it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.