[Webkit-unassigned] [Bug 105451] Unable to place caret in RTL Override Characters by mouse click

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105451





--- Comment #9 from Ryosuke Niwa <rniwa at webkit.org>  2013-01-10 17:52:09 PST ---
(From update of attachment 182230)
View in context: https://bugs.webkit.org/attachment.cgi?id=182230&action=review

The description makes sense but I need to re-familiarize myself with bidi resolver before I can review this patch.

> Source/WebCore/platform/text/BidiResolver.h:509
> +        if (run && (run->stop() - run->start() == 1)) {

Why do we do this only when the difference between the start and the stop is 1?

> Source/WebCore/platform/text/BidiResolver.h:510
> +            BidiContext* c = context();

Please don't use one letter variable.

> Source/WebCore/platform/text/BidiResolver.h:511
> +            while (c->parent())

Is this correct with respect to the way we implement unicode-bidi: -webkit-isolate and unicode-bidi: -webkit-plaintext?
I definitely would like to see tests for these.

> LayoutTests/editing/selection/click-on-rtl-text.html:10
> +<div id="description">This test that clicking on the editable RTL text correctly places the caret between the RTL characters.</div>
> +<textarea id="editor" cols="100" rows="3">a&#8238;AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA

Could you create a LTR equivalent?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.