[Webkit-unassigned] [Bug 105548] [CSS Grid Layout] Add the plumbing to parse -webkit-grid-{column, row}-span

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105548





--- Comment #2 from Julien Chaffraix <jchaffraix at webkit.org>  2013-01-10 16:11:23 PST ---
(From update of attachment 180500)
> The two things I consider are probably up for debate:
> - I use GridPosition to store the span, it might be better to create a new type (GridSpan?)
> - I actually store the span in the item data. Perhaps it would be better to store a second GridPosition (m_gridColumnEnd, m_gridRowEnd?), and figure out the span doing end-start.

I don't think it makes sense to have GridPosition embeds the span information: it will be difficult not to store both the span and the end GridPosition as dynamic updates could easily add / remove or update one or the other - including changing the order in which they occur. Also the end GridPosition would override the span if present which adds some complexity and could make the transition tricky if we try to save on storing the spans.

Also, we should be careful not to move the parsing too much forward with respect to implementing the layout (if only to keep some feature detection for the early adopters). The current grammar is correlated with a subset of the layout that is powerful enough (auto sizing, minmax), yet whose complexity is manageable. Adding support for spanning columns / rows adds a lot of complexity which I would rather delay until minmax implementation is stable enough.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.