[Webkit-unassigned] [Bug 106548] [chromium] move webpermissionclient related methods to TestRunner library

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 10 08:21:26 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=106548


jochen at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #182143|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #5 from jochen at chromium.org  2013-01-10 08:23:18 PST ---
(From update of attachment 182143)
very nice!

View in context: https://bugs.webkit.org/attachment.cgi?id=182143&action=review

> Tools/ChangeLog:65
> +        (normalizeLayoutTestURLInternal):

please update the changelog

> Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:86
> +    , m_webPermissions(adoptPtr(new WebPermissions()))

nit no () required after WebPermissions

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list