[Webkit-unassigned] [Bug 106475] Web Inspector: Correct formatting in inspector-test.js

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 10 07:23:49 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=106475





--- Comment #4 from johnjbarton <johnjbarton at chromium.org>  2013-01-10 07:25:41 PST ---
(In reply to comment #3)
> (From update of attachment 181956 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=181956&action=review
> 
> > LayoutTests/http/tests/inspector/inspector-test.js:333
> > +    InspectorTest.addConsoleSniffer = function(override, opt_sticky)
> 
> As I mentioned, we don't indent namespaces / closures like this. Like this like looks really weird now.

Can you help me understand? What makes this function different from other functions? I don't know what a namespace is in JavaScript and we have many other closures which are indented. (I also think that from a practical point of view this rule is bizarre but at least I'd like to know when to apply it).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list