[Webkit-unassigned] [Bug 105846] [WK2][EFL] Add guard around NativeWebTouchEvent

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 9 23:15:33 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=105846


Gyuyoung Kim <gyuyoung.kim at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |




--- Comment #21 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2013-01-09 23:17:24 PST ---
(In reply to comment #18)
> > >> With a few exceptions, the feature #ifdef should be on the #include side, not in the header.
> > 
> > I have no strong opinion on this, but it seems to me #ifdef has been using in header in many places. For example, Modules sub-directories. But, I don't wanna object your opinion.
> 
> You are right, I am thinking of touch events header in particular. If I am not mistaken, those use the style I mentioned above (right?).
> 
> For me the difference ties into a feature in development, and optional features like touch events.

It looks there is no rule for this. However, I prefer to tie .h and .cpp together with #ifdef guard personally if there is #ifdef guard for those files. I think it will prevent unexpected build break on other ports. But, I'm not sure if this should become one of coding style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list