[Webkit-unassigned] [Bug 105846] [WK2][EFL] Add guard around NativeWebTouchEvent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105846





--- Comment #18 from Benjamin Poulain <benjamin at webkit.org>  2013-01-09 22:48:25 PST ---
> >> With a few exceptions, the feature #ifdef should be on the #include side, not in the header.
> 
> I have no strong opinion on this, but it seems to me #ifdef has been using in header in many places. For example, Modules sub-directories. But, I don't wanna object your opinion.

You are right, I am thinking of touch events header in particular. If I am not mistaken, those use the style I mentioned above (right?).

For me the difference ties into a feature in development, and optional features like touch events.

(In reply to comment #16)
> > Source/WebKit2/Shared/efl/NativeWebTouchEventEfl.cpp:26
> >  #include "config.h"
> 
> I prefer to add a new line below config.h, if possible.

+1 :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.