[Webkit-unassigned] [Bug 103867] [Resource Timing] redirectStart & redirectEnd time need to be recorded to populate resource timing entries

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103867





--- Comment #6 from pdeng6 <pan.deng at intel.com>  2013-01-09 19:01:37 PST ---
(In reply to comment #5)
> (From update of attachment 180661 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=180661&action=review
> 
> > Source/WebCore/loader/cache/CachedResource.h:265
> > +#if ENABLE(RESOURCE_TIMING)
> > +    double redirectStartTime() const { return m_redirectStartTime; }
> > +    double redirectEndTime() const { return m_redirectEndTime; }
> > +    void addRedirect(double);
> > +#endif
> > +
> 
> How will this be accessed, and what is the correct behavior if the CachedResource is reused?
> 
> This patch may be ok, but I can't be sure without clearly understanding whether it's correct to reuse this data in the case of a cache hit.

Thanks, it will be accessed in CachedResourceLoader::loadDone(CachedResource* resource), same way as resource->resourceRequest(), resource->response() and resource->loadFinishTime(). see https://bugs.webkit.org/show_bug.cgi?id=103777, and landed patch https://bugs.webkit.org/attachment.cgi?id=177328&action=review.

Timing information will be reported only once when resource is loaded, and not reported when hit from memory cache, it is also similar to response() of CachedResource(http://www.w3.org/TR/2012/CR-resource-timing-20120522/#processing-model)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.