[Webkit-unassigned] [Bug 103220] [GTK] Build with LevelDB when IndexedDB is enabled

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 9 15:17:05 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=103220





--- Comment #16 from David Grogan <dgrogan at chromium.org>  2013-01-09 15:18:58 PST ---
(In reply to comment #15)
> (In reply to comment #14)
> > (In reply to comment #6)
> > 
> > > From what I've seen so far, the big stumbling block is helpers/memenv/memenv.h which is apparently not considered part of the library, but is used by many leveldb users. Otherwise it looks decent if not aimed at typical shared distribution (Makefile doesn't even have an install target). 
> > 
> > I don't know if it's used by many leveldb users. We added it to leveldb for chrome's incognito mode. Do GTK or EFL support something similar? If not, we could #ifdef chromium around memenv and then you won't have to worry about it.
> 
> If we add leveldb to Sources/ThirdParty, memenv shouldn't be an issue. This seems to be the way to go since WebKit needs to depend on a particular version (which distributions might not ship).

Agreed that including a full copy of leveldb in ThirdParty is the way to go.

> Can you comment on the amount of API/ABI-breaking changes that happen in leveldb and WebKit's IDB implementation?

There's been one API change in the past year. Code using the old API would not work with the new API but code using the new API would work with the old API. Does that fit this definition of "breaking"?

I don't know much about ABI changes, we always recompile. ABI compatibility has never been considered a goal of the leveldb project, though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list