[Webkit-unassigned] [Bug 102828] r134080 causes heap problem on linux systems where PAGESIZE != 4096

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102828


Balazs Kilvady <kilvadyb at homejinni.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #176212|0                           |1
        is obsolete|                            |
 Attachment #176212|review?                     |
               Flag|                            |
 Attachment #181941|                            |review?
               Flag|                            |




--- Comment #12 from Balazs Kilvady <kilvadyb at homejinni.com>  2013-01-09 10:16:09 PST ---
Created an attachment (id=181941)
 --> (https://bugs.webkit.org/attachment.cgi?id=181941&action=review)
proposed patch.

We are not satisfied with this patch, but would like to start a discussion. One possible solution is what we did in the patch: to introduce a new base class which defines the block size for the HeapBlocks in question (forcing a common value). Another possible solution would be to just introduce a new constant for this purpose and use it as the default value for both the blockSize in the heap blocks and the  gcMarkStackSegmentSize option.

An other option is to fix MarkStackArray to use block size of heap blocks. We aren't sure if gcMarkStackSegmentSize is good to use in MarkStackArray implementation as it depends on MarkStackSegment::blockSize.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.