[Webkit-unassigned] [Bug 105846] [WK2][EFL] Add guard around NativeWebTouchEvent

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 9 09:37:08 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=105846


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #181876|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #12 from Benjamin Poulain <benjamin at webkit.org>  2013-01-09 09:39:00 PST ---
(From update of attachment 181876)
(In reply to comment #11)
> (From update of attachment 181876 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=181876&action=review
> 
> > Source/WebKit2/Shared/efl/NativeWebTouchEventEfl.cpp:27
> > +#if ENABLE(TOUCH_EVENTS)
> 
> NativeWebTouchEventEfl.cpp already uses this guard. 

You can just move that guard up under the #include of config.h.

> I think this build break occurs because NativeWebTouchEvent.h doesn't use the guard. I think it would be good to add this guard to NativeWebTouchEvent.h.

See my previous comments.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list