[Webkit-unassigned] [Bug 105458] [chromium] Add WebLayer::setIgnoresContinuousPainting() API and use it to ignore the PageOverlay's layer.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 9 09:30:17 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=105458





--- Comment #13 from egraether at chromium.org  2013-01-09 09:32:10 PST ---
(In reply to comment #12)
> (From update of attachment 181704 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=181704&action=review
> 
> Seems pretty reasonable to me.  I think it'd be a good idea to try to not add all the new code to WebViewImpl but instead have it off in a separate class that WebViewImpl owns and manages, just to keep the code size down.  Nat - WDYT?

Having a separate file for this one method seems a bit overdone in my opinion. Or do you think there will be other stuff added? What would you call this class?

What about adding the method to the GraphicsLayer instead:
GraphicsLayer::setNeedsDisplayForContinuousPaintingRecursive()

with a member and method to ignore the overlay's layer:
GraphicsLayer::setIgnoresContinuousPainting()

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list