[Webkit-unassigned] [Bug 100225] [EFL][WK2] Add APIs to get/set the default text encoding name

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100225





--- Comment #13 from Christophe Dumez <christophe.dumez at intel.com>  2013-01-08 21:56:26 PST ---
(From update of attachment 180964)
View in context: https://bugs.webkit.org/attachment.cgi?id=180964&action=review

>>> Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp:62
>>> +    m_defaultTextEncoding = defaultTextEncoding.utf8().data();
>> 
>> Seems saved 'm_defaultTextEncoding' isn't used elsewhere.
>> Then, can we remove it?
> 
> This is incorrect. The char buffer is invalid pas that line.
> You need to hold on the CString if you want to keep a character buffer alive.

m_defaulltTextEncoding is not a char* but a WKEinaSharedString. The string is actually copied so the code is correct. This is bit of a particularity of EFL port since our APIs returns EINA Stringshared strings.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.