[Webkit-unassigned] [Bug 96592] Ruby text is incorrectly positioned when its writing-mode is changed to vertical after layout is done

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96592





--- Comment #11 from Yuki Sekiguchi <yuki.sekiguchi at access-company.com>  2013-01-07 21:57:33 PST ---
(In reply to comment #7)
> (From update of attachment 171772 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=171772&action=review
> 
> > LayoutTests/fast/writing-mode/ruby-text-logical-left.html:26
> > +      setTimeout(function () {
> 
> Although there is no JS style guide for WebKit project, we usually follows one of C++,
> that means we does 4-space indent. See other tests as examples.

I understand it and fixed.

> > LayoutTests/fast/writing-mode/ruby-text-logical-left.html:27
> > +        var e = document.getElementById("test1");
> 
> Please don't use abbreviation for the variable name.

Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.