[Webkit-unassigned] [Bug 105846] Add guard around NativeWebTouchEvent

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 7 18:34:03 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=105846





--- Comment #5 from Seokju Kwon <seokju.kwon at gmail.com>  2013-01-07 18:35:59 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > (From update of attachment 180913 [details] [details] [details])
> > > With a few exceptions, the feature #ifdef should be on the #include side, not in the header.
> > > 
> > > Why is this case different?
> > 
> > NativeWebTouchEvent was derived from WebTouchEvent. But it is around ENABLE(TOUCH_EVENTS) in header file (WebEvent.h).
> > It seems that build breaks when TOUCH_EVENTS is disabled.
> 
> I understand that. But why #ifdef the header instead of in the code where the header is included?

Sorry, I was confused. I will upload a new patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list