[Webkit-unassigned] [Bug 106068] Assert in RenderGeometryMap::mapToContainer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106068





--- Comment #5 from Alexandru Chiculita <achicu at adobe.com>  2013-01-04 14:40:39 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > Looks like the layer requirements are calculated before a layout was ever done. m_everHadLayout is 0 on the renderer that reproduces the problem. This should have no visual issues in practice as a layout will follow anyway and that will fix any eventual issues.
> 
> But it is crazy to rely on overlap rectangles when we haven't been laid out yet! We are in updateCompositingLayersAfterLayout() though, so someone is lying.

I know, I guess for that one the solution is to trigger a layout if needed and only if there was no layout just go ahead update just the compositing layers. 

I've also added an ASSERT in updateCompositingLayers for !m_renderView->needsLayout() and after running the tests I've also found the following case:

ASSERTION FAILED: !m_renderView->needsLayout()
/Source/WebCore/rendering/RenderLayerCompositor.cpp(411) : void WebCore::RenderLayerCompositor::updateCompositingLayers(WebCore::CompositingUpdateType, WebCore::RenderLayer *)
1   0x10ae78bd3 WebCore::RenderLayerCompositor::updateCompositingLayers(WebCore::CompositingUpdateType, WebCore::RenderLayer*)
2   0x10ae4483e WebCore::RenderLayer::updateCompositingLayersAfterScroll()
3   0x10ae44346 WebCore::RenderLayer::scrollTo(int, int)
4   0x10ae46d1e WebCore::RenderLayer::setScrollOffset(WebCore::IntPoint const&)
5   0x10b093bb0 WebCore::ScrollableArea::scrollPositionChanged(WebCore::IntPoint const&)
6   0x10b093ea1 WebCore::ScrollableArea::setScrollOffsetFromAnimation(WebCore::IntPoint const&)
7   0x10b0963eb WebCore::ScrollAnimator::notifyPositionChanged()
8   0x10b09a759 WebCore::ScrollAnimatorMac::notifyPositionChanged()
9   0x10b09a2a2 WebCore::ScrollAnimatorMac::immediateScrollTo(WebCore::FloatPoint const&)
10  0x10b09a1c3 WebCore::ScrollAnimatorMac::scrollToOffsetWithoutAnimation(WebCore::FloatPoint const&)
11  0x10b0939fc WebCore::ScrollableArea::scrollToOffsetWithoutAnimation(WebCore::FloatPoint const&)
12  0x10ae43ba2 WebCore::RenderLayer::scrollToOffset(WebCore::IntSize const&, WebCore::RenderLayer::ScrollOffsetClamping)
13  0x10adbc433 WebCore::RenderLayer::scrollToXOffset(int, WebCore::RenderLayer::ScrollOffsetClamping)
14  0x10aea43ad WebCore::RenderMarquee::timerFired(WebCore::Timer<WebCore::RenderMarquee>*)
15  0x10aea5853 WebCore::Timer<WebCore::RenderMarquee>::fired()
16  0x10b3e37e6 WebCore::ThreadTimers::sharedTimerFiredInternal()
17  0x10b3e3579 WebCore::ThreadTimers::sharedTimerFired()
18  0x10b112543 WebCore::timerFired(__CFRunLoopTimer*, void*)
19  0x7fff8bb64da4 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__
20  0x7fff8bb648bd __CFRunLoopDoTimer
21  0x7fff8bb4a099 __CFRunLoopRun
22  0x7fff8bb496b2 CFRunLoopRunSpecific
23  0x7fff90e510a4 RunCurrentEventLoopInMode
24  0x7fff90e50e42 ReceiveNextEventCommon
25  0x7fff90e50cd3 BlockUntilNextEventMatchingListInMode
26  0x7fff8c2a5613 _DPSNextEvent
27  0x7fff8c2a4ed2 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:]
28  0x7fff8c29c283 -[NSApplication run]
29  0x10b043afc WebCore::RunLoop::run()
30  0x107a09563 WebKit::WebProcessMain(WebKit::CommandLine const&)
31  0x1078f3459 WebKitMain(WebKit::CommandLine const&)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.