[Webkit-unassigned] [Bug 106034] MediaControls::show() should make controls opaque

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106034





--- Comment #2 from Eric Carlson <eric.carlson at apple.com>  2013-01-04 09:44:15 PST ---
(From update of attachment 181221)
View in context: https://bugs.webkit.org/attachment.cgi?id=181221&action=review

> Source/WebCore/ChangeLog:8
> +        When a video enters fullscreen, webkit starts a timer to make the control transparent when the timer expires. If the user exits fullscreen while the timer expires, webkit will call mediaControls::show(). However, show() actually displays nothing as the control is transparent. The user had to move his mouse outside the video rect and move it back in order to show the controls. Simply clicking/moving the mouse inside the video rect will not make the control opaque.

Please wrap this line, not every code editor is set to auto-wrap.

> LayoutTests/media/video-controls-visible-exiting-fullscreen.html:11
> +        var fadeoutTime = 4000;

Four seconds is a very long time for a layout test. Does it need to be this long?

> LayoutTests/media/video-controls-visible-exiting-fullscreen.html:21
> +        var oncanplaythrough = function() {

Nit: It seems strange to have some functions declared as a variable with an anonymous function and some with a function declaration.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.