[Webkit-unassigned] [Bug 84778] webkit fails IETC column-width-negative-001.htm

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 3 12:09:08 PST 2013


Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
 Attachment #181199|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |

--- Comment #4 from Tony Chang <tony at chromium.org>  2013-01-03 12:11:06 PST ---
(From update of attachment 181199)
View in context: https://bugs.webkit.org/attachment.cgi?id=181199&action=review

The change looks fine, but the test could be better.  I see some red at the edges of the letters due to text antialiasing which is confusing.

I would convert this from a ref test to a dumpAsText test (they run faster and are easier to know if it passes or fails) and use fast/js/resources/js-test-pre.js.  The change has to do with CSS parsing, so you could simply have a div with column-width: 0 and read the value back out using getComputedStyle (it should be auto).

> LayoutTests/fast/multicol/column-width-zero.html:15
> +                -moz-column-width: 0em;

0 shouldn't have a unit.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list