[Webkit-unassigned] [Bug 106012] [SOUP] Convert WebSoupRequestManagerProxy to be WebContextSupplement

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 3 10:16:27 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=106012





--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-01-03 10:18:26 PST ---
(In reply to comment #3)
> (From update of attachment 181167 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=181167&action=review
> 
> > Source/WebKit2/ChangeLog:7
> > +        https://bugs.webkit.org/show_bug.cgi?id=106012
> > +
> > +        Reviewed by NOBODY (OOPS!).
> > +
> 
> Could use a bit of context here or in the bug about why it makes sense to switch to this to a WebContextSupplement, for posterity.

To make the WebContext code more simple and cleaner, same reaoning as bug #105890, for example.

> > Source/WebKit2/UIProcess/soup/WebSoupRequestManagerProxy.cpp:98
> > +    if (!context())
> > +        return;
> 
> What's the mechanism by which the context becomes NULL. 

WebContextSupplement::clearContext()

> It's passed in as an argument, so does it become invalid at some point during the lifetime of the object?

It's cleared in the WebContext destructor, some supplements have the checks and some other don't, so I decided to include to be extra sure.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list