[Webkit-unassigned] [Bug 106012] [SOUP] Convert WebSoupRequestManagerProxy to be WebContextSupplement

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 3 09:11:13 PST 2013


--- Comment #3 from Martin Robinson <mrobinson at webkit.org>  2013-01-03 09:13:12 PST ---
(From update of attachment 181167)
View in context: https://bugs.webkit.org/attachment.cgi?id=181167&action=review

> Source/WebKit2/ChangeLog:7
> +        https://bugs.webkit.org/show_bug.cgi?id=106012
> +
> +        Reviewed by NOBODY (OOPS!).
> +

Could use a bit of context here or in the bug about why it makes sense to switch to this to a WebContextSupplement, for posterity.

> Source/WebKit2/UIProcess/soup/WebSoupRequestManagerProxy.cpp:98
> +    if (!context())
> +        return;

What's the mechanism by which the context becomes NULL. It's passed in as an argument, so does it become invalid at some point during the lifetime of the object?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list