[Webkit-unassigned] [Bug 105728] [BlackBerry] Update BB10 media render theme.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 2 15:07:54 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=105728


Yong Li <yoli at rim.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #181075|review?                     |review+
               Flag|                            |




--- Comment #10 from Yong Li <yoli at rim.com>  2013-01-02 15:09:54 PST ---
(From update of attachment 181075)
View in context: https://bugs.webkit.org/attachment.cgi?id=181075&action=review

LGTM. But it doesn't apply to webkit ToT? You may want John to review it again.

> Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:1089
>      static Image* mediaSliderThumb = Image::loadPlatformResource("core_media_handle").leakRef();
> -
> +    if (!isEnabled(object))

minor: a space here would be nice.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list