[Webkit-unassigned] [Bug 105473] Implement :future pseudo class for the WebVTT ::cue pseudo element

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 2 14:38:43 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=105473


Antti Koivisto <koivisto at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #180558|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #10 from Antti Koivisto <koivisto at iki.fi>  2013-01-02 14:40:43 PST ---
(From update of attachment 180558)
View in context: https://bugs.webkit.org/attachment.cgi?id=180558&action=review

Looks good, r=me. Please fix the style issues.

> Source/WebCore/css/StyleResolver.cpp:1243
> +    if (element->isWebVTTNode() !=  m_element->isWebVTTNode())

extra space after !=

> Source/WebCore/dom/NodeRareData.h:276
>          , m_childrenAffectedByBackwardPositionalRules(false)
> +#if ENABLE(VIDEO_TRACK)
> +    , m_WebVTTNodeType(TextTrack::WebVTTNodeTypeNone)
> +#endif

intendation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list