[Webkit-unassigned] [Bug 105728] [BlackBerry] Update BB10 media render theme.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105728





--- Comment #8 from Yong Li <yoli at rim.com>  2013-01-02 14:09:30 PST ---
(From update of attachment 181059)
View in context: https://bugs.webkit.org/attachment.cgi?id=181059&action=review

> Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:1135
> +    static Image* volumeBar = Image::loadPlatformResource("core_slider_played_bg").leakRef();
> +    // This is to paint main volume slider bar.

A space between 1134 and 1135 would be neat.

> Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:1140
> +    bool result = paintSliderTrackRect(object, paintInfo, rect2, volumeBackground);
> +
> +    if (volume > 0) {
> +        // This is to paint volume bar (left of volume slider thumb) using selection color.
> +        paintSliderTrackRect(object, paintInfo, volumeRect, volumeBar);

I'm confused here. should it be

result |= paintSliderTrackRect(object, paintInfo, volumeRect, volumeBar);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.