[Webkit-unassigned] [Bug 105728] [BlackBerry] Update BB10 media render theme.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105728


Yong Li <yoli at rim.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #181059|review?                     |review-
               Flag|                            |




--- Comment #7 from Yong Li <yoli at rim.com>  2013-01-02 14:06:14 PST ---
(From update of attachment 181059)
View in context: https://bugs.webkit.org/attachment.cgi?id=181059&action=review

> Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:1094
> +    static Image* mediaSliderThumb;
> +    if (!isEnabled(object))
> +        mediaSliderThumb = Image::loadPlatformResource("core_slider_handle_disabled").leakRef();
> +    else {
> +        if (isPressed(object) || isHovered(object) || isFocused(object))
> +            mediaSliderThumb = Image::loadPlatformResource("core_slider_handle_pressed").leakRef();
> +        else
> +            mediaSliderThumb = Image::loadPlatformResource("core_media_handle").leakRef();
> +    }

will this leak an image every time? I would use 3 static Image* objects that are initialized upon first time, and then reused.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.