[Webkit-unassigned] [Bug 100225] [EFL][WK2] Add APIs to get/set the default text encoding name
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 1 18:02:06 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=100225
--- Comment #10 from Gyuyoung Kim <gyuyoung.kim at samsung.com> 2013-01-01 18:04:07 PST ---
(From update of attachment 180964)
View in context: https://bugs.webkit.org/attachment.cgi?id=180964&action=review
> Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp:59
> + if (defaultTextEncoding.isEmpty())
I wonder what meaning this condition has. Because, isEmpty() just checks if String has a character at least or null. Look at isEmpty() function.
bool isEmpty() const { return !m_impl || !m_impl->length(); }
However, I think "preferences()->defaultTextEncodingName()" won't be null. So, it seems to me that this condition isn't needed, doesn't it ?
Is below enough ?
m_defaultTextEncoding = preferences()->defaultTextEncodingName().utf8().data();
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list