[Webkit-unassigned] [Bug 108565] [CPP, GObject, ObjC] Add 'enum' skip to CodeGenerator{CPP, GObject, ObjC}.pm

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108565


Nils Barth <nbarth at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #185941|                            |review?
               Flag|                            |




--- Comment #6 from Nils Barth <nbarth at google.com>  2013-01-31 21:57:17 PST ---
Created an attachment (id=185941)
 --> (https://bugs.webkit.org/attachment.cgi?id=185941&action=review)
Patch

(In reply to comment #2)
> (From update of attachment 185936 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=185936&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        Add IsEnumType test to SkipAttribute in legacy code generators.
> 
> Please explain the rationale for the change, not only what you did but also why you did it.
> 
> e.g. Since CodeGenerator{CPP,GObject,ObjC}.pm does not support 'enum', this patch adds code to skip DOM attributes that return 'enum'.
Got it -- fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.