[Webkit-unassigned] [Bug 108565] [CPP, GObject, ObjC] Add 'enum' skip to CodeGenerator{CPP, GObject, ObjC}.pm

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108565


Kentaro Hara <haraken at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #185936|review?                     |review+
               Flag|                            |




--- Comment #2 from Kentaro Hara <haraken at chromium.org>  2013-01-31 21:32:52 PST ---
(From update of attachment 185936)
View in context: https://bugs.webkit.org/attachment.cgi?id=185936&action=review

> Source/WebCore/ChangeLog:8
> +        Add IsEnumType test to SkipAttribute in legacy code generators.

Please explain the rationale for the change, not only what you did but also why you did it.

e.g. Since CodeGenerator{CPP,GObject,ObjC}.pm does not support 'enum', this patch adds code to skip DOM attributes that return 'enum'.

> Source/WebCore/bindings/scripts/test/TestObj.idl:47
>      static readonly attribute long     staticReadOnlyLongAttr;
>      static attribute DOMString         staticStringAttr;
>      static readonly attribute TestSubObjConstructor TestSubObj;
> -    attribute TestEnumType             enumAttr;
>  #endif

I think you can remove this #if too by skipping 'static' in CodeGenerator{ObjC,GObject,CPP}.pm. You can do it in a follow-up patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.