[Webkit-unassigned] [Bug 108509] [Chromium] Select multi-word misspelling on context click

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108509


Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #185887|commit-queue?, review?      |commit-queue-, review+
               Flag|                            |




--- Comment #8 from Tony Chang <tony at chromium.org>  2013-01-31 16:35:49 PST ---
(From update of attachment 185887)
View in context: https://bugs.webkit.org/attachment.cgi?id=185887&action=review

I had suggested moving in a follow up change because now the diff doesn't show your changes.  Anyway, this is OK too.

> Source/WebKit/chromium/src/ContextMenuClientImpl.cpp:149
> +// Helper function to get misspelling on which context menu is to be invoked
> +// for asynchronous spellcheck. This function changes the selection only when
> +// there were no selected characters.

Remove this comment.

> Tools/DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:120
> +    if (word == WebString::fromUTF8("wellcome"))
> +        append(suggestions, WebString::fromUTF8("welcome"));

Why do we copy and swap?  Why can't we append to |suggestions| directly?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.