[Webkit-unassigned] [Bug 108509] [Chromium] Select two-word misspelling on context-click
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 31 15:08:01 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=108509
Tony Chang <tony at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #185850|review?, commit-queue? |review+, commit-queue-
Flag| |
--- Comment #2 from Tony Chang <tony at chromium.org> 2013-01-31 15:10:02 PST ---
(From update of attachment 185850)
View in context: https://bugs.webkit.org/attachment.cgi?id=185850&action=review
As a follow up, it would be nice if we moved the spellchecking code into a helper function out of getCustomMenuFromDefaultItems() since that function is > 200 lines.
> Source/WebKit/chromium/src/ContextMenuClientImpl.cpp:295
> + if (markerRange->startOffset() == selectionRange->startOffset() && markerRange->endOffset() == selectionRange->endOffset()) {
Could you use WebCore::areRangesEqual() here instead of comparing start and end?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list