[Webkit-unassigned] [Bug 108498] [Chromium] Add two-word misspelling to mock spellchecker

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108498


Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #185809|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #3 from Tony Chang <tony at chromium.org>  2013-01-31 11:23:55 PST ---
(From update of attachment 185809)
View in context: https://bugs.webkit.org/attachment.cgi?id=185809&action=review

You can use "webkit-patch land-safely" to reupload the patch and forward on the r+.

> Tools/DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:76
> +        int maxWordLength = static_cast<int>(stringText.length()) - wordOffset;
> +        int wordLength;

I think you would have fewer casts if you made all the length types unsigned.  Conceptually, a negative length doesn't make sense.

> Tools/DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:167
> +        m_misspelledWords.append(WTF::String::fromUTF8(misspelledWords[i]));

Nit: remove WTF::

> Tools/DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:73
> +    Vector<WTF::String> m_misspelledWords;

Nit: remove WTF::

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.