[Webkit-unassigned] [Bug 107737] Editor::m_compositionNode not updated on HTMLInputElement::setValue()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107737





--- Comment #41 from Aurimas Liutikas <aurimas at chromium.org>  2013-01-31 11:17:10 PST ---
(From update of attachment 185795)
View in context: https://bugs.webkit.org/attachment.cgi?id=185795&action=review

>> Source/WebKit/chromium/ChangeLog:12
>> +        This bug already had a test that had expectation set to fail, but now it will be passing.
> 
> This explanation should probably be done in Source/WebCore/ChangeLog instead.

Done.

>> Source/WebCore/editing/Editor.cpp:1340
>> +    unsigned start, end;
> 
> WebKit style is to define each variable on its own line.

Done.

>> Source/WebKit/mac/WebView/WebHTMLView.mm:6048
>>          [[NSInputManager currentInputManager] markedTextSelectionChanged:NSMakeRange(start, end - start) client:self];
> 
> Now this code is executed even if hasComposition() and coreFrame->editor()->ignoreCompositionSelectionChange() are both false.
> r- because of this.

My refactoring does not really work for the Mac port (it does for all other ports) so I am leaving the code in this file as it was.

>> LayoutTests/ChangeLog:10
>> +        and the WebViewClient should get notified about this cancellation.
> 
> This comment applies to Source/WebCore or Source/WebKit, not LayoutTests. Please remove.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.