[Webkit-unassigned] [Bug 107737] Editor::m_compositionNode not updated on HTMLInputElement::setValue()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107737


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #185795|review?                     |review-
               Flag|                            |




--- Comment #39 from Ryosuke Niwa <rniwa at webkit.org>  2013-01-31 09:44:32 PST ---
(From update of attachment 185795)
View in context: https://bugs.webkit.org/attachment.cgi?id=185795&action=review

> Source/WebCore/ChangeLog:7
> +

Please describe the nature of your change.

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

Please explain that an existing test, editing/input/setting-input-value-cancel-ime-composition.html, covers this change.

> Source/WebCore/ChangeLog:22
> +
> +        * WebCore.exp.in:
> +        * editing/Editor.cpp:
> +        (WebCore::Editor::cancelCompositionIfSelectionIsInvalid):
> +        (WebCore):
> +        * editing/Editor.h:
> +        (Editor):

Why is this repeated here?

> Source/WebKit/chromium/ChangeLog:12
> +        Adding a check whether composition is valid after the selection change.
> +        If there is no valid composition, then the composition should get cancelled
> +        and the WebViewClient should get notified about this cancellation.
> +
> +        This bug already had a test that had expectation set to fail, but now it will be passing.

This explanation should probably be done in Source/WebCore/ChangeLog instead.

> Source/WebKit/mac/WebView/WebHTMLView.mm:6048
>      if (coreFrame->editor()->getCompositionSelection(start, end))
>          [[NSInputManager currentInputManager] markedTextSelectionChanged:NSMakeRange(start, end - start) client:self];

Now this code is executed even if hasComposition() and coreFrame->editor()->ignoreCompositionSelectionChange() are both false.
r- because of this.

> LayoutTests/ChangeLog:10
> +        Adding a check whether composition is valid after the selection change.
> +        If there is no valid composition, then the composition should get cancelled
> +        and the WebViewClient should get notified about this cancellation.

This comment applies to Source/WebCore or Source/WebKit, not LayoutTests. Please remove.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.