[Webkit-unassigned] [Bug 107831] [chromium] Make selection handling work in applyPageScaleInCompositor mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107831





--- Comment #7 from Ryosuke Niwa <rniwa at webkit.org>  2013-01-30 20:18:11 PST ---
(From update of attachment 185621)
View in context: https://bugs.webkit.org/attachment.cgi?id=185621&action=review

> Source/WebKit/chromium/src/WebFrameImpl.cpp:1386
> +    if (frame()->page()->settings()->applyPageScaleFactorInCompositor()) {
> +        unscaledExtent.scale(1 / view()->pageScaleFactor(), 1 / view()->pageScaleFactor());
> +        unscaledBase.scale(1 / view()->pageScaleFactor(), 1 / view()->pageScaleFactor());
> +    }

I think you should be calling visibleContentScaleFactor() instead since frame's page scaling factor is not necessarily equal to view's page scaling factor. See ScrollView::visibleContentRect for example.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.