[Webkit-unassigned] [Bug 107772] Adds usage instrumentation for indexedDB

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107772





--- Comment #19 from Joshua Bell <jsbell at chromium.org>  2013-01-30 16:52:02 PST ---
(From update of attachment 185552)
View in context: https://bugs.webkit.org/attachment.cgi?id=185552&action=review

Overall this seems fine to me. Sorry about the churn! It might be worth grepping for IDB_TRACE to see were we've instrumented other API call sites for performance.

> Source/WebCore/Modules/indexeddb/IDBHistograms.h:35
> +    IDBCreateObjectStoreCall,

About half the histograms explicitly set the first item to = 0. Shouldn't be necessary.

Would this benefit from a comment that this list should only be added to, since these values are sent over the wire? or is the fact that this lives in a Histograms file clear enough?

Also, although not important for this set, perhaps a convention of IDB<objectname><methodname> would be good to introduce, to eventually disambiguate IDBObjectStore::openCursor from IDBIndex::openCursor. That can also be done later, though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.