[Webkit-unassigned] [Bug 106187] [Mac Lion] [WK2] tiled-drawing tests are being run when they shouldn’t be

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106187





--- Comment #15 from Dirk Pranke <dpranke at chromium.org>  2013-01-30 16:35:10 PST ---
Yup, buggy error message (the two line numbers are swapped).

At any rate, you can't have both qualified and unqualified lines in a single file like that. As the comment you found indicates, having multiple lines that both match a single configuration is an error. We used to support more-specific overriding less-specific, but it seemed to be unwarranted complexity.

In this case, I would replace the two lines:

platform/mac/tiled-drawing/ [ Pass ]                           
[ Lion ] platform/mac/tiled-drawing/ [ Skip ]                                   

With just:

[ MountainLion ] platform/mac/tiled-drawing/ [ Pass ]

There is no current way to "futureproof" things so that all WK1 and only Lion WK2 is skipped. You would need to add either a specific WK1 TestExpectations file or add support for WK1 and WK2 keywords. I would recommend doing the former, especially if you plan to continue deprecating WK1 on Apple Mac more and more.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.