[Webkit-unassigned] [Bug 108259] Coordinated Graphics : Remove WebCoordinatedSurface dependency from CoordinatedSurface
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 30 15:43:11 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=108259
Benjamin Poulain <benjamin at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #185456|review? |review-
Flag| |
--- Comment #6 from Benjamin Poulain <benjamin at webkit.org> 2013-01-30 15:45:09 PST ---
(From update of attachment 185456)
View in context: https://bugs.webkit.org/attachment.cgi?id=185456&action=review
I sign off on this change, Noam can review this for WebKit2.
> Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedSurface.cpp:18
> +/*
> + Copyright (C) 2013 Company 100, Inc.
> +
> + This library is free software; you can redistribute it and/or
> + modify it under the terms of the GNU Library General Public
> + License as published by the Free Software Foundation; either
> + version 2 of the License, or (at your option) any later version.
> +
> + This library is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + Library General Public License for more details.
> +
> + You should have received a copy of the GNU Library General Public License
> + along with this library; see the file COPYING.LIB. If not, write to
> + the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
> + Boston, MA 02110-1301, USA.
> + */
Not the standard header.
> Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedSurface.cpp:24
> +#include "config.h"
> +
> +#if USE(COORDINATED_GRAPHICS)
> +
> +#include "CoordinatedSurface.h"
Should be:
#include "config.h"
#include "CoordinatedSurface.h"
#if FOOBAR
> Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedSurface.cpp:43
> +#endif // USE(COORDINATED_GRAPHICS)
> +
> +} // namespace WebKit
the #define does not match the namespace scope.
> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:119
> + // CoordinatedSurface
Useless comment.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list