[Webkit-unassigned] [Bug 108311] [chromium] Add convenience functions for geometry query

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108311





--- Comment #4 from James Robinson <jamesr at chromium.org>  2013-01-30 13:40:23 PST ---
(From update of attachment 185435)
View in context: https://bugs.webkit.org/attachment.cgi?id=185435&action=review

> Source/WebKit/chromium/public/WebFrame.h:172
> +    // Returns the visible content rect (minus scrollbars, in absolute coordinate)

blank line before new functions

how does this interact with contentsSize() + scrollOffset() ?

> Source/WebKit/chromium/src/WebViewImpl.cpp:4378
> +    physicalWindowRect.scale(deviceScaleFactor() * pageScaleFactor());

I don't understand this function. device and page scale factors are exposed through the WebKit API, why do we need another WebKit API entry point just to multiply them together?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.