[Webkit-unassigned] [Bug 106553] [V8] Add IDL 'enum' support to CodeGeneratorV8.pm

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106553





--- Comment #25 from Kentaro Hara <haraken at chromium.org>  2013-01-29 18:25:03 PST ---
"String string = v" looks fine.

> > 3. How should I be comparing strings?
> >   v is a V8StringResource I believe, which doesn't have a comparison,
> >   so I'm casting it to String and comparing those, which works;
> >   is it The Right Way to do it?
> 
> That's a good question.  Haraken might have some insight, but conversion to a String makes sense in this case because we'll need the String version in the common case anyway (i.e., when the comparisons pass).

It's a right usage of V8StringResource. V8StringResource is a "meta" class of String and AtomicString. V8StringResource is expected to be used by being implicitly converted into String or AtomicString when you need to access a string.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.