[Webkit-unassigned] [Bug 106553] [V8] Add IDL 'enum' support to CodeGeneratorV8.pm

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 29 17:08:14 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=106553





--- Comment #22 from Nils Barth <nbarth at google.com>  2013-01-29 17:10:13 PST ---
(In reply to comment #18)
> (In reply to comment #17)
> > Q: Should we break this up into a few patches (for ease of review etc.)?
> > It would be easy to make it 2 patches:
> > one for basic parser/code gen guts, one for V8.
> 
> Actually I'd like to go without splitting. If you split the patch further, you cannot test individual patches. The basic approach would be "split your patch into reviewable-size patches but don't split your patch into untestable-size patches".

Got it -- changing guts doesn't change behavior until it's used, so the only test would be "doesn't break/same as before", but doesn't show that it does what it's supposed to -- it's just an invisible internal change.
(Only when there's some visible change can you tell that it works.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list