[Webkit-unassigned] [Bug 107772] Adds usage instrumentation for indexedDB

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 29 14:51:56 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=107772





--- Comment #14 from Joshua Bell <jsbell at chromium.org>  2013-01-29 14:53:55 PST ---
(From update of attachment 185159)
View in context: https://bugs.webkit.org/attachment.cgi?id=185159&action=review

> Source/WebCore/ChangeLog:6
> +        abarth at webkit.org

This should be left as "Reviewed by NOBODY (OOPS!)." until the patch actually has an r+ from a reviewer.

> Source/WebCore/ChangeLog:7
> +        jsbell at chromium.org

...and I'm not a reviewer (which is a special role in WebKit), just an interested bystander. :)

> Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp:376
> +    HistogramSupport::histogramEnumeration("WebCore.IndexedDB", IDBOpen, IDBMethodsMax);

In theory, this could be derived from the number of OpenResult histogram entries, but given the branching in this method I agree that adding this would be beneficial.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list