[Webkit-unassigned] [Bug 107406] Collapse PLATFORM(MAC)||PLATFORM(IOS) to just PLATFORM(MAC)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107406


Laszlo Gombos <laszlo.gombos at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |INVALID




--- Comment #12 from Laszlo Gombos <laszlo.gombos at webkit.org>  2013-01-29 06:37:31 PST ---
Thanks David for the review !

> > Source/JavaScriptCore/runtime/DatePrototype.cpp:65
> > -#if PLATFORM(MAC) || PLATFORM(IOS) || (PLATFORM(WX) && OS(DARWIN)) || (PLATFORM(QT) && OS(DARWIN))
> > +#if PLATFORM(MAC) || (PLATFORM(WX) && OS(DARWIN)) || (PLATFORM(QT) && OS(DARWIN))
> >  #include <CoreFoundation/CoreFoundation.h>
> 
> This #if should probably be:  #if USE(CF)

Filed bug to turn the guard to "OS(DARWIN) && USE(CF)" - see bug 108018.

Filed a bug to get rid of "OS(DARWIN)" part and just use USE(CF) - see bug 108188 .

Somewhat off topic - I also filed a bug for the Gtk Mac port to hit this code path - see bug 107492.

> > Source/WebCore/config.h:148
> >  // CoreAnimation is available to IOS, Mac and Windows if using CG
> > -#if PLATFORM(MAC) || PLATFORM(IOS) || (PLATFORM(WIN) && USE(CG))
> > +#if PLATFORM(MAC) || (PLATFORM(WIN) && USE(CG))
> >  #define WTF_USE_CA 1
> >  #endif
> 
> This exact code is already in Source/WTF/wtf/Platform.h, and <wtf/Platform.h> is included in config.h above.  It should just be removed.

Filed bug 108016 - it does not look like though that we can just remove these lines from config.h as that would break the WIN build. 

I think all the issues discussed here are now covered by the new bugs filed so I propose to close this bug.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.