[Webkit-unassigned] [Bug 108183] New: Web Inspector: Create a container class for SidebarPane instances

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108183

           Summary: Web Inspector: Create a container class for
                    SidebarPane instances
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: kaznacheev at chromium.org
                CC: keishi at webkit.org, pmuellr at yahoo.com,
                    pfeldman at chromium.org, yurys at chromium.org,
                    apavlov at chromium.org, loislo at chromium.org,
                    vsevik at chromium.org,
                    web-inspector-bugs at googlegroups.com


Although WebInspector.SidebarPane has been recently converted to inherit from WebInspector.View there are still some things that are wrong with it:
1. Some inheritors of WebInspector.SidebarPane do lazy initialization in some strange places (such as expand method), not in wasShown as a decent View should.
2. The client code directly inserts SidebarPane instances into DOM, then these instances change their appearance in expand/collapse methods.

There is a better way:
1. SidebarPane instances should live in a dedicated container (SidebarPaneStack).
2. SidebarPaneStack should take care of displaying pane title text, title buttons and collapse/expand behavior (calling show/detach).

This should make for a cleaner code and simplify further refactoring (replacing SidebarPaneStack with a special kind of a tabbed pane when the sidebar width > height).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.